Skip to content

Conversation

@LilyL0u
Copy link
Contributor

@LilyL0u LilyL0u commented Jan 7, 2026

https://bbc.atlassian.net/browse/WS-1945

Migrated topic page tests to next js app as part of the migration of pages to next js. Deletes tests from src/app.

This pull request also adds and refactors integration tests for the topic pages, focusing on improving test coverage for page content and curation features. It introduces a shared test suite for verifying topic page content, applies this suite to multiple services, and updates relevant snapshot files to reflect the new and updated tests.

Test Coverage Improvements:

  • Added a new shared test suite in pageContentTests.ts to verify key aspects of topic page content, such as the first item's headline and image, the presence of curation grids, and the main HTML tag structure.
  • Integrated the new pageContentTests into the existing cross-platform tests (crossPlatformTests.ts) and the mundo topic page tests, ensuring consistent content validation across services. [1] [2]

Snapshot and Test File Updates:

  • Added and updated Jest snapshot files for the mundo and pidgin topic pages to capture expected headlines, images, badge images, and descriptions as part of the new and expanded tests. [1] [2]
  • Updated snapshot references for SEO-related attributes (such as canonical URLs and Open Graph data) to reflect changes in the local test server port, ensuring test accuracy. [1] [2] [3] [4]Resolves JIRA:

Summary

A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.

Code changes

  • A bullet point list of key code changes that have been made.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@LilyL0u LilyL0u changed the title move the files to ws-nextjs-app and change to ts WS-1945 Migrate Integration tests (Topic Page) Jan 7, 2026
@LilyL0u LilyL0u marked this pull request as ready for review January 13, 2026 16:16
@amoore108
Copy link
Contributor

Could you add a link to the JIRA ticket and a brief description in the PR?

@LilyL0u LilyL0u merged commit 73416b4 into latest Jan 13, 2026
13 checks passed
@LilyL0u LilyL0u deleted the WS-1945-migrate-topic-page-integration-tests branch January 13, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants